Thread is still in the catalogue but I can't post in it anymore because it is too deep. This really makes no sense to me.
Today my PLD assigned me to be the reviewer of a pull request of him.
He made some minor changes but the changes touched a couple of tests that he had written a while ago.
None of these tests made any kind of sense. He basically just created a data object that is somewhere defined in the code and asserted whether the default values were really assigned. In other tests he made some logical operations of those default values and then asserted the logical operation in this test to be true/false. I commented this on the pull request and approved it expecting him to remove those tests. Usually we always just approve pull requests and trust that the other one will make the changes you require of him so you don't have to review it twice.
He didn't made the changes and just merged the pull request.
After I noticed it I called him and asked him to give me the reasons why he did not made the changes I requested.
He couldn't really answer those questions. Those logical operations he checked were copied from some class were the object is used but he didn't expose those methods but rather copied the code. He wasn't able to tell me why he did said. He also said that those logical operations he checked for were already different in the actual class where they are used in the software.
So he basically agreed with all my points of criticism but didn't act on them.
I was at a loss of words on this.
This was not the first time he did this. I'm on vacation for the next week but when I come back and he didn't fix this I will make an appointment with him and the manager to talk this through. I didn't want to make the appointment today because I'm boiling inside due to this and need to cool off before.
Bernd
2023-09-15 19:21:03 ⋅ 1y
No. 287918
Do you have a test coverage policy?
Bernd
2023-09-15 19:22:35 ⋅ 1y
No. 287919
>>287918
No. I think sonar cube displays it somewhere but I haven't looked at it in years.
Bernd
2023-09-15 19:26:12 ⋅ 1y
No. 287920
>>287919
IDK then, maybe he is about to quit and doesn't care.
Bernd
2023-09-15 19:27:25 ⋅ 1y
No. 287921
>>287917
> Usually we always just approve pull requests and trust that the other one will make the changes you require of him so you don't have to review it twice.
oh no, Bernd
think of it as a valuable lesson to never trust anyone and not approve anything until the actual changes are made
Bernd
2023-09-15 19:31:02 ⋅ 1y
No. 287923
>>287920
I doubt it.
I think he is just generally a bad programmer. Judging from his writing style he has a weak form of dyslexia and he is really really sloppy.
>>287921
He is my team leader. If he does not want to do the changes I request he might just merge anyway. I doubt that this would have changed anything. I need to escalate this.
Bernd
2023-09-15 19:34:36 ⋅ 1y
No. 287925
>>287923
> I doubt that this would have changed anything.
result-wise probably not, but now he can say you approved it and he'd be right
I'm curious how this will end
Bernd
2023-09-15 19:43:49 ⋅ 1y
No. 287928
>>287925
We are not the kind of team were anyone would lie to save his ass and I talked to him afterwards so he can't say that there were any misunderstandings.
Only thing they can say against me is that I'm an autist that is too perfectionistic in his demands [spoiler] and they are probably right with it [/spoiler] But clean code is not negotiable.
Bernd
2023-09-15 19:53:59 ⋅ 1y
No. 287931
>>287921
We do the same, never had any problems with that. Not being able to trust your teammates seems like a very unhealthy environment to me.
Bernd
2023-09-15 21:32:53 ⋅ 1y
No. 287954
Bernd
2023-09-15 21:47:25 ⋅ 1y
No. 287955
>>287954
>sounds like a compliment to me
Oh, you. Stop it you charming charmer.
Bernd
2023-09-16 10:03:06 ⋅ 1y
No. 288061
>>287955
never!
are you doing anything for you vacation?
Bernd
2023-09-16 15:14:47 ⋅ 1y
No. 288071
>>288061
I will drive to the alps to hike for a couple of days.
Bernd
2023-09-16 19:34:25 ⋅ 1y
No. 288097
>>288071
aren't you afraid of getting lost or being eaten by a bear?
Bernd
2023-09-16 19:57:15 ⋅ 1y
No. 288102
>>288097
I am. I fear being eaten by a bear every single day. But if I stay inside all the time the bear has won already. I won't make it that easy for him.
Did you go somewhere this year for vacation?
Bernd
2023-09-16 23:33:09 ⋅ 1y
No. 288127
>>288102
problem Bear will come to your home.
Bernd
2023-09-17 00:05:32 ⋅ 1y
No. 288131
I am incapable of supporting myself.
Bernd
2023-09-17 08:29:45 ⋅ 1y
No. 288188
>>288127
I don't open the door for bears.
Bernd
2023-09-17 18:19:57 ⋅ 1y
No. 288257
>>288102
that's good, you can't be a slave to your fears [spoiler]but you should get a pepper spray or one of those personal alarms - it's loud as hell and I bet it would make a bear run away[/spoiler]
I haven't taken much time off this year, apart from a couple of days for running personal errands; we have a new guy at work who is supposed to cover for me in some projects and he's fresh out of uni so I don't want to leave him to fend for himself before I can relay all relevant knowledge [spoiler]I mean, I could do that but then I'd feel bad for him[/spoiler]
but I am planning to go to Rome in January/February, depending on my postgrad program schedule, so here's that
Bernd
2023-09-17 20:20:40 ⋅ 1y
No. 288277
>>288257
There are no bears where I am going. I wonder why you are so afraid of them. There seem to be almost no bears on the poland.
Will you do me a favor and scratch my name into the colosseum?
Bernd
2023-09-17 20:56:01 ⋅ 1y
No. 288287
>>288277
I'm just worried for you, I have virtually zero chance meeting a bear since I don't prowl the wilderness [spoiler]unless I accidentally fall into the bear enclosure at the local ZOO[/spoiler]
> Will you do me a favor and scratch my name into the colosseum?
only if you break me out of prison when they inevitably catch me vandalizing landmarks
Bernd
2023-09-18 13:25:15 ⋅ 1y
No. 288374
>>288287
>only if you break me out of prison
Sweetie if someone -anyone- even dares to lay a finger on you [spoiler] I will go haywire on their pull requests if I get the chance [/spoiler]
Bernd
2023-09-18 17:43:00 ⋅ 1y
No. 288395
>>288374
are you trying to sweet talk me into vandalizing the Colosseum?
Bernd
2023-09-18 18:07:14 ⋅ 1y
No. 288397
>>288395
Cutie, the code you write today -which prevents your from taking holidays- will last one decade, maybe two decades at most. But having our names manifested in the stone of the colloseum will last hundreds if not thousands of years.
Hundred thousands of tourists will see the name Bernd on the colloseum and might be slightly annoyed by this crude vandalism. This is the most impact on the world and the lives of other people that we could ever wish for.
If they catch you you will be world famous. Your cute little mugshot will be admired and adored by thousands of people.
Why wouldn't you want to take part in that?
Bernd
2023-09-19 14:33:18 ⋅ 1y
No. 288500
>>288397
> will last one decade, maybe two decades at most
ha! the result of my work is going to end up in the municipal archive (I'm not even kidding)
would you like to be famous? because it sounds like a lot of work
Bernd
2023-09-19 16:01:01 ⋅ 1y
No. 288510
>>288500
Oh so you are shaping the world indeed. Does it feel gratifying to do this?
>would you like to be famous?
That's a very broad term. You could be famous for being the biggest alcoholic in town or a serial rapist. I doubt that I want to have that. But usually fame comes with social status and that is a defining factor in male attractivity. I wouldn't say no to that.
Bernd
2023-09-19 16:39:11 ⋅ 1y
No. 288516
>>288510
it's awful, but I'm going to feel great when I'm finally done [spoiler]not because it's an accomplishment, but because I won't have to spend another second thinking about it[/spoiler]
> But usually fame comes with social status and that is a defining factor in male attractivity.
is it? how so? aren't people more attracted to the fame itself than the actual person underneath?
Bernd
2023-09-19 16:52:40 ⋅ 1y
No. 288519
>>288516
>it's awful
what makes it awful?
>aren't people more attracted to the fame itself than the actual person underneath?
irrelevant as long as it is attached to you.
Attractive people have an easier live overall because other people like to have them around. Also being attractive in whatever way will make more people want to have contact with you which will make it easier for you to find someone that likes yourself underneath.
Bernd
2023-09-20 14:28:57 ⋅ 1y
No. 288620
>>288287
Is this a bear? He stares at me with malicious intend I think. Shall I run?
Bernd
2023-09-20 17:57:40 ⋅ 1y
No. 288641
>>288519
> what makes it awful?
the schema I'm working with is like... if someone one day learned databases are a thing, got very excited, followed a bunch of tutorials of dubious quality, made a giant clusterfuck of a schema as a result, then got bored and forgot about it; and now it's 25 years later and I need to make sense of it [spoiler]without any documentation because fuck me[/spoiler]
> irrelevant as long as it is attached to you.
I don't know, wouldn't it feel insincere?
>>288620
yes, that is a bear, but luckily for you it's the kind that rarely feasts on human flesh
have you tried petting it?
Bernd
2023-09-21 14:09:23 ⋅ 1y
No. 288696
>>288641
Whenever I hear somebody talk about databases I feel like I dodged a bullet by never having to deal with them in my life so far.
I wouldn‘t touch an unknown bear. One of them even blocked the trail and I went out of my way to not come within 2 metres of it. Should be somewhat safe here when there are no calves around but life is no Disney movie.
Bernd
2023-09-21 14:46:53 ⋅ 1y
No. 288701
>>288696
it's so pretty! are you enjoying yourself?
> I feel like I dodged a bullet by never having to deal with them in my life so far
why?
> One of them even blocked the trail and I went out of my way to not come within 2 metres of it
did you at least tell her she has the shiniest hooves you've ever seen?
Bernd
2023-09-23 08:12:38 ⋅ 1y
No. 288964
>>288701
It is pretty but only if you don't turn your head to see the loads of other tourists around you. Also for me the view severely lacked the satisfaction of going up there with my own legs as I just drove up with ans cable car.
The whole area was a bit too touristy for my tastes. I think I prefer my Mittelgebirge for hiking. I will return to the alps to climb a mountain from bottom to top in a day or two. But I have to find the right one first.
>why?
those query languages feel clunky and non-intuitive. It seems like once the schema is established it becomes superhard to change anything. And you usually don't know enough make it right when you set it up. Over time the database and reality move away from each other until you have to migrate the database which is a huge pain in the ass. Tell me where I'm wrong.
>her she has the shiniest hooves you've ever seen?
No. I was already at a point of exhaustion that my brain stopped to work properly. I wondered if I could push her hard enough down the slope of the hill to make her fall down if she started to attack me.
Bernd
2023-09-23 11:46:17 ⋅ 1y
No. 288975
>>288964
oh, I'm not saying you're wrong [spoiler](because you're not)[/spoiler], I just wanted to know what you think
seeing as these aren't wild cows they shouldn't take your mere presence as a threat; so unless you make sudden movements I'd say you should be good; but if you need to defend yourself a swift punch to the nose should do [spoiler]and don't run, you'll never outrun a cow[/spoiler]
[spoiler]and to think I was worried about bears when it's innocent grass-eating cows who turned out to be the real menace[/spoiler]
Bernd
2023-09-23 19:01:29 ⋅ 1y
No. 289010
>>288975
Why do you know so much about cows? The amount of specialist knowledge you have for almost every topic is impressive.
I find them scary. They are 700kg worth of [spoiler] mostly stomach probably [/spoiler] .
I doubt that a cow would have any problem to kill a human. They just don't bother to do it.
Bernd
2023-09-25 05:19:17 ⋅ 1y
No. 289164
>>288975
real. Why would you hurt a cow? please check out my thread, its of a similar topic: https://krautchan.rip/int/278241
also dont report me
Bernd
2023-09-25 13:49:57 ⋅ 1y
No. 289203
>>289010
I was bitten by a radioactive cow and now I'm an (or perhaps even [i]the[/i]) expert in all things bovine
> They just don't bother to do it.
turns out sometimes they do https://www.bbc.com/news/uk-scotland-south-scotland-66188057
>>289164
> Why would you hurt a cow?
I wouldn't unless in self defense, don't you think that's reasonable?
Bernd
2023-09-25 13:50:10 ⋅ 1y
No. 289204
>Thread is still in the catalogue but I can't post in it anymore because it is too deep. This really makes no sense to me.
It's made to replicate 404 of threads on standard imageboards.
Bernd
2023-09-25 18:06:42 ⋅ 1y
No. 289228
>>289204
If you archived threads that were pushed out of the catalogue and someone saved the link to them I would understand that behavior but not for threads that are still in the catalogue.
Update to the OP:
I spend last week thinking about the best way to escalate the situation without burning all the bridges to my PLD. Today I looked in git and noticed that he basically did all the changes I asked from him sometime last week. So that is that.
Also I'm currently at a C# conference in another town and the secretary at wörk that booked the hotel room for me didn't turn on the checkbox that my employer would pay for the room. Usually it would not be a problem for me to pay and then give the bill to my employer but for the love of god I couldn't remember the pin of my card, anymore. I must have entered this pin a thousand times in my life but I could not remember it anymore. So I entered the wrong pin three times and then my card was locked. And I don't have enough cash at hand. Standing in a hotel lobby 150km away from home. Thankfully they let me in my room under the premise that I talk to the secretary tomorrow and make her set the checkbox on booking.com that my employer will pay.
This was maybe my worst experience of this year so far. I'm looking so forward to being back in my usual routine when this is over. I can't deal with stressful situations like this.
Bernd
2023-09-25 21:40:46 ⋅ 1y
No. 289262
>>289228
how long is the conference? what will you be doing during it? are you dreading the networking part?
> I can't deal with stressful situations like this.
but you did deal with it (and fairly well by the sound of it, despite the stress), so you clearly are capable of such things
[spoiler]you should tell us your PIN in case you ever forget it again[/spoiler]
Bernd
2023-09-26 12:03:12 ⋅ 1y
No. 289335
>>289262
Conference is this whole week. But Im only allowed to attend until tomorrow by my employer. It mainly consist of talks about the current IT buzzwords. This year its obviously very AI focused. There are also exhibitors that try to sell you their frameworks. I just attend the talks and only talk the minimum to other people which works fairly well with IT guys.
It is well attended this year. So far Ive counted less than 15 females and one tranny on 500+ males.
[spoiler] my PIN is 2663 but dont tell it to anyone else [/spoiler]