Thread is still in the catalogue but I can't post in it anymore because it is too deep. This really makes no sense to me.
Today my PLD assigned me to be the reviewer of a pull request of him.
He made some minor changes but the changes touched a couple of tests that he had written a while ago.
None of these tests made any kind of sense. He basically just created a data object that is somewhere defined in the code and asserted whether the default values were really assigned. In other tests he made some logical operations of those default values and then asserted the logical operation in this test to be true/false. I commented this on the pull request and approved it expecting him to remove those tests. Usually we always just approve pull requests and trust that the other one will make the changes you require of him so you don't have to review it twice.
He didn't made the changes and just merged the pull request.
After I noticed it I called him and asked him to give me the reasons why he did not made the changes I requested.
He couldn't really answer those questions. Those logical operations he checked were copied from some class were the object is used but he didn't expose those methods but rather copied the code. He wasn't able to tell me why he did said. He also said that those logical operations he checked for were already different in the actual class where they are used in the software.
So he basically agreed with all my points of criticism but didn't act on them.
I was at a loss of words on this.
This was not the first time he did this. I'm on vacation for the next week but when I come back and he didn't fix this I will make an appointment with him and the manager to talk this through. I didn't want to make the appointment today because I'm boiling inside due to this and need to cool off before.